[bug#61975] [PATCH] gnu: i3-wm: Add missing propagated inputs.

[SeerLite]

Hi!

On 3/6/23 08:30, 宋文武 wrote:

> SeerLite <seerlite@disroot.org> writes:
>
> > perl-anyevent-i3 is necessary to run i3-save-tree.
> >
> > * gnu/packages/wm.scm (i3-wm)[propagated-inputs]: Add perl and perl-anyevent-i3.
> > ---
> >  gnu/packages/wm.scm | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> > index 5b8dbd5c70..8816f110bb 100644
> > --- a/gnu/packages/wm.scm
> > +++ b/gnu/packages/wm.scm
> > @@ -356,6 +356,8 @@ (define-public i3-wm
> >             startup-notification
> >             pango
> >             cairo))
> > +    (propagated-inputs
> > +     (list perl perl-anyevent-i3))
> >       
> Hello, this can also be done by 'wrap-program' i3-save-tree with
> PERL5LIB.  And a wrapper is considered better than propagated-input here
> due to the latter will introduce perl and its libraries into user's
> profile, which may not be what a typical i3 user want and will also
> increase the chance of conflicts in profile.
>
> Could you send an update patch to use 'wrap-program' for i3-save-tree?
> Thank you!
>     
    Done! I also updated the package to the gexp style. I hope it was a
    good idea, I'm not sure if I did it right.
    
    When I was doing as you said with wrap-program I noticed
    i3-save-tree complained about many more missing libraries, so I
    added those too. I don't understand why those don't report as
    missing with my v1 patch. I'm testing with guix shell --pure.
    These libraries are definitely not coming from my profile when
    propagating. Was it maybe perl-anyevent-i3 propagating them?
    
    Also, I'm not sure where to put the perl input. Should I remove it
    from native-inputs? Or would it be needed in both inputs and
    native-inputs? It's used both at build time and after installation
    by i3-save-tree.
    
    Thank you for the comments!
    
    SeerLite