[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#61959] [PATCH 0/7] Add some Asahi Linux packages
From: |
Roman Scherer |
Subject: |
[bug#61959] [PATCH 0/7] Add some Asahi Linux packages |
Date: |
Sun, 05 Mar 2023 11:53:46 +0100 |
User-agent: |
mu4e 1.8.13; emacs 29.0.60 |
Hi Ricardo,
I updated the patch series and sent v2 of it.
Thanks for your review!
Roman
Ricardo Wurmus <rekado@elephly.net> writes:
> Thank you for the patches.
>
> Here a couple of comments:
>
> * Please do not use Github archive URLs like
> "https://github.com/AsahiLinux/m1n1/archive/v….tar.gz". These are
> automatically generated and have changed in the past, leading to
> different hashes. In the interest of reproducibility please use
> “git-fetch” with plain commit hashes instead.
>
> * Please use G-expressions instead of simple quoting with (assoc-ref
> outputs "out"). Instead of this:
>
> --8<---------------cut here---------------start------------->8---
> (arguments
> `(#:phases
> (modify-phases %standard-phases
> (replace 'configure
> (lambda _
> (setenv "RELEASE" "1")))
> (replace 'install
> (lambda* (#:key outputs #:allow-other-keys)
> (let ((dir (string-append (assoc-ref outputs "out")
> "/libexec/")))
> (mkdir-p dir)
> (copy-file "build/m1n1.bin" (string-append dir "m1n1.bin")))))
> ;; There are no tests
> (delete 'check))))
> --8<---------------cut here---------------end--------------->8---
>
>
> Please do this:
>
> --8<---------------cut here---------------start------------->8---
> (arguments
> (list
> ;; There are no tests
> #:tests? #false
> #:phases
> #~(modify-phases %standard-phases
> (replace 'configure
> (lambda _
> (setenv "RELEASE" "1")))
> (replace 'install
> (lambda _
> (let ((dir (string-append #$output "/libexec/")))
> (mkdir-p dir)
> (copy-file "build/m1n1.bin" (string-append dir
> "m1n1.bin"))))))))
> --8<---------------cut here---------------end--------------->8---
>
> This also applies to “asahi-fwextract”.
>
> * The string labels for inputs are a deprecated style. Please use plain
> lists of package variables. If you want to modify an inherited list
> of inputs such as in “asahi-mesa” please use “modify-inputs”.
>
> * In “asahi-fwextract” the build phase “'remove-vendor” should be a
> source snippet instead.
>
> * Please use pyproject-build-system instead of python-build-system. The
> pyproject-build-system is going to be the default in the future, and
> it would be good to use it already to address any incompatibilities
> early.
>
> Could you please send a new version of this patch set? Thanks again!
signature.asc
Description: PGP signature
- [bug#61959] [PATCH 0/7] Add some Asahi Linux packages, Roman Scherer, 2023/03/04
- [bug#61959] [PATCH 1/7] gnu: Add m1n1., Roman Scherer, 2023/03/04
- [bug#61959] [PATCH 2/7] gnu: Add u-boot-apple-m1., Roman Scherer, 2023/03/04
- [bug#61959] [PATCH 5/7] gnu: Add asahi-mesa., Roman Scherer, 2023/03/04
- [bug#61959] [PATCH 6/7] gnu: Add asahi-mesa-headers., Roman Scherer, 2023/03/04
- [bug#61959] [PATCH 3/7] gnu: Add asahi-fwextract., Roman Scherer, 2023/03/04
- [bug#61959] [PATCH 4/7] gnu: libdrm: Update to 2.4.114., Roman Scherer, 2023/03/04
- [bug#61959] [PATCH 7/7] gnu: Add asahi-mesa-utils., Roman Scherer, 2023/03/04
- [bug#61959] [PATCH 0/7] Add some Asahi Linux packages, Ricardo Wurmus, 2023/03/04
- [bug#61959] [PATCH 0/7] Add some Asahi Linux packages,
Roman Scherer <=
- [bug#61959] [PATCH 0/7] Add some Asahi Linux packages, Winter, 2023/03/04
- [bug#61959] [PATCH v2 1/7] gnu: Add m1n1., Roman Scherer, 2023/03/05
- [bug#61959] [PATCH v2 2/7] gnu: Add u-boot-apple-m1., Roman Scherer, 2023/03/05
- [bug#61959] [PATCH v2 4/7] gnu: Add asahi-fwextract., Roman Scherer, 2023/03/05
- [bug#61959] [PATCH v2 5/7] gnu: Add asahi-mesa., Roman Scherer, 2023/03/05
- [bug#61959] [PATCH v2 7/7] gnu: Add asahi-mesa-utils., Roman Scherer, 2023/03/05
- [bug#61959] [PATCH v2 3/7] gnu: libdrm: Update to 2.4.114., Roman Scherer, 2023/03/05
- [bug#61959] [PATCH v2 6/7] gnu: Add asahi-mesa-headers., Roman Scherer, 2023/03/05
- [bug#61959] [PATCH v3 0/7] Add some Asahi Linux packages, Roman Scherer, 2023/03/05