[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#57945: [PATCH] gnu: wpa-supplicant: enable OWE support
From: |
Ludovic Courtès |
Subject: |
bug#57945: [PATCH] gnu: wpa-supplicant: enable OWE support |
Date: |
Wed, 28 Sep 2022 22:41:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi,
Maxime Devos <maximedevos@telenet.be> skribis:
> On 20-09-2022 01:59, Andreas Rammhold wrote:
>> + (add-after 'configure 'enable-owe
>> + (lambda _
>> + (let ((port (open-file ".config" "al")))
>> + (display "CONFIG_OWE=y\n" port)
>> + (close-port port))
>> + #t))
>
>
> (1) Why not do this in the 'configure' phase instead?
> (2) Trailing #t in phases aren't required anymore since a long time,
> you can remove them.
> (3) You are not a committer (and you are the author), so you can't
> 'push the commit on behalf on somebody else'. From (guix)Commit
Good points (perhaps somewhat intimidating for a newcomer).
Andreas, I applied a variant of the patch that accounts for the comments
Maxime made.
Thank you!
Ludo’.