|
From: | Maxime Devos |
Subject: | [bug#57857] [PATCH] gnu: busybox: fix the cross build. |
Date: | Sun, 25 Sep 2022 19:55:35 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 |
On 16-09-2022 17:53, 路辉 wrote:
Can be simplified: #:make-flags ,(let ((target ,(%current-target-system)))
Oops the , before (%current-target-system) shouldn't be there
(if target #~(list (string-append "CROSS_COMPILE=" ,target))
OOps, ,target -> #$target
#~'())) (the #~ makes the phasing more explicit, if you go for that, I recommend turning the arguments into (arguments (list #:phases #~(modify-phases ...) #:make-flags ...)), instead of using ` / , , to remain consistent.) Greetings, Maximenew patch vvvv
The #:make-flags simplification is missing (it can help with avoiding rebuilds (e.g. if a particular architecture needs some different #:make-flags than usual), but otherwise looks good.
Greetings, Maxime.
OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
[Prev in Thread] | Current Thread | [Next in Thread] |