[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57460] [PATCH 00/19] Refresh to specific version
From: |
Ludovic Courtès |
Subject: |
[bug#57460] [PATCH 00/19] Refresh to specific version |
Date: |
Sat, 24 Sep 2022 11:34:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * guix/import/kde.scm(latest-kde-release): Rename to (import-kde-release), add
> keyword-argument 'version'. Rework the code to not sort the relevant files,
> but just find the requested or latest version.
> [find-latest-archive-version]: New function.
(Same comment.)
[...]
> + ;; find latest version
> + (version (or version
> + (and (not (null? relevant))
> + (tarball->version (find-latest-archive-version
> relevant)))))
> + ;; find archives matching this version
> + (archives (filter (lambda (file)
> + (string=? version (tarball->version file)))
> + relevant)))
I think you can remove the comments or make them proper sentences
(capitalized and with a period). I’d prefer to keep the name ‘tarballs’
rather than ‘archives’ because it’s less ambiguous IMO.
> + (match archives
> + (() #f)
> + (_
Please reindent it as it was.
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version,
Ludovic Courtès <=
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24
- [bug#57460] [PATCH 00/19] Refresh to specific version, Ludovic Courtès, 2022/09/24