[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#57694: [PATCH 1/1] import: gem: Support for importing a specified ve
From: |
Christopher Baines |
Subject: |
bug#57694: [PATCH 1/1] import: gem: Support for importing a specified version of a gem. |
Date: |
Sat, 17 Sep 2022 19:18:41 +0200 |
User-agent: |
mu4e 1.8.9; emacs 28.1 |
Taiju HIGASHI <higashi@taiju.info> writes:
> Hi Chris,
>
> Could you give me your opinion on this patch?
> Is this patch worth it?
Hey,
Unfortunately I haven't had much time to look at Ruby stuff recently,
but these changes look good to me. I tweaked a few minor things and
pushed this as c967d1153cae419e4acbe0dbed8f558d95ced0e3.
Thanks,
Chris
> Taiju HIGASHI <higashi@taiju.info> writes:
>
>> * guix/import/gem.scm: (rubygems-fetch, gem->guix-package)
>> (gem-recursive-import): Fix to fetch the specified version of the gem.
>> * guix/scripts/import/gem.scm (show-help): Modify the help message.
>> (guix-import-gem): Modify the version number to be passed to subsequent
>> procedures
>> * tests/gem.scm: Add tests.
>> ---
>> guix/import/gem.scm | 19 ++++--
>> guix/scripts/import/gem.scm | 39 +++++++------
>> tests/gem.scm | 113 ++++++++++++++++++++++++++++++++++++
>> 3 files changed, 148 insertions(+), 23 deletions(-)
signature.asc
Description: PGP signature