[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57737] Thanks for your reviews!
From: |
zimoun |
Subject: |
[bug#57737] Thanks for your reviews! |
Date: |
Wed, 14 Sep 2022 09:09:17 +0200 |
Hi Nicolas,
Thank you for your contribution. Neat!
Next time, if I might, I would suggest the use of the option
--reroll-count from ’git format-patch’ and increases the number at each
new revision of the patch series. It helps for following, IMHO. :-)
On Tue, 13 Sep 2022 at 23:50, Nicolas Graves via Guix-patches via
<guix-patches@gnu.org> wrote:
> @Maxime: would be happy to change that to format, but I haven't used
> that much and don't understand what the _G refers to -- I don't see it
> in the documentation either at first glance.
Indeed, it is not well-documented. The definition from (guix i18n)
reads,
(define G_ (cut gettext <> %gettext-domain))
which allows to extract the string and then process it for translation.
Although it is huge task, package synopsis and description are
translated too! ;-)
Usually, you just need to wraps the resulting string with (G_ …). Does
it not work if instead you write,
--8<---------------cut here---------------start------------->8---
(description (G_ (string-append "\
This package provides a consistent ESS-like evaluation interface for
" lang " REPLs. [...]")))
--8<---------------cut here---------------end--------------->8---
? Well, I think,
--8<---------------cut here---------------start------------->8---
(description (G_ "\
This package provides a consistent ESS-like evaluation interface for
~s REPLs. [...]"
lang))
--8<---------------cut here---------------end--------------->8---
should fit the bill; or something along these lines. :-)
Cheers,
simon
- [bug#57737] [PATCH 4/6] gnu: Add emacs-eval-in-repl packages., (continued)
[bug#57737] [PATCH 1/7] gnu: emacs-elixir-mode: Move package for eval-in-repl definition., Nicolas Graves, 2022/09/13
- [bug#57737] [PATCH 3/7] gnu: Add emacs-js-comint., Nicolas Graves, 2022/09/13
- [bug#57737] [PATCH 4/7] gnu: Add emacs-alchemist., Nicolas Graves, 2022/09/13
- [bug#57737] [PATCH 2/7] gnu: Add emacs-eval-in-repl., Nicolas Graves, 2022/09/13
- [bug#57737] [PATCH 7/7] gnu: Add emacs-org-babel-eval-in-repl., Nicolas Graves, 2022/09/13
- [bug#57737] [PATCH 5/7] gnu: Add emacs-eval-in-repl packages., Nicolas Graves, 2022/09/13
- [bug#57737] [PATCH 6/7] gnu: Add emacs-ob-elm., Nicolas Graves, 2022/09/13
[bug#57737] Thanks for your reviews!, Nicolas Graves, 2022/09/13
- [bug#57737] Thanks for your reviews!,
zimoun <=
[bug#57737] [PATCH v4 1/6] gnu: Add emacs-eval-in-repl., Nicolas Graves, 2022/09/16
[bug#57737] [PATCH v4 1/2] gnu: Add emacs-ob-elm., Nicolas Graves, 2022/09/16
[bug#57737] sorry again for the broken sent, Nicolas Graves, 2022/09/16