[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57646] [PATCH] etc: teams: Add regular expression support to scopes
From: |
Mathieu Othacehe |
Subject: |
[bug#57646] [PATCH] etc: teams: Add regular expression support to scopes. |
Date: |
Mon, 12 Sep 2022 15:49:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hey,
> * the dependency on Guile-Git means that the script must be run inside a
> suitable environment now, whereas previously it had no dependencies
> other than Guile. If we can assume that people use Guix perhaps we
> should do what doc/build.scm does and use Guix to arrange for
> dependencies to be available.
Right, for now I went for the easiest solution and proposed the following
example in the documentation:
--8<---------------cut here---------------start------------->8---
$ guix shell -D guix
[env]$ git send-email $(./etc/teams.scm cc-members HEAD~2 HEAD) *.patch
--8<---------------cut here---------------end--------------->8---
> * I don’t like the “if” + “null?” pattern:
>
> + (if (not (null? (team-scope team)))
> + (format #f "scope: ~{~s ~}~%" (team-scope team))
> + ""))
>
> I’d prefer using match:
>
> (match (team-scope team)
> (() "")
> (scope (format #f "scope: ~{~s ~}~%" scope)
>
> * With Liliana’s added support for regexes, the previous patch to record
> scopes for the installer etc should be adjusted.
Fixed!
Thanks,
Mathieu