[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#44518] gnu: Add matterhorn.
From: |
( |
Subject: |
[bug#44518] gnu: Add matterhorn. |
Date: |
Sat, 10 Sep 2022 13:06:40 +0100 |
Hi,
This patch must have slipped through the cracks, but it was mentioned
on IRC today, so I decided to do a little review :)
First of all,
(1) You should have one commit per package.
(2) It's better, though not required, to use the procedure described here[1]
to send patches, instead of using attachments. This makes it much easier
to annotate the patch with review comments, at least here in aerc :)
[1]
https://paste.sr.ht/~unmatched-paren/9114b1fa3d2088c7c71307dcae0d9e2b3620eb0c
> + (inputs
> + `(("ghc-random" ,ghc-random)
> + ("ghc-quickcheck" ,ghc-quickcheck)
> + ("ghc-semigroupoids" ,ghc-semigroupoids)))
You should use the "new style" of inputs:
> + (inputs
> + (list ghc-random
> + ghc-quickcheck
> + ghc-semigroupoids))
Same for any native- and propagated- inputs.
> + (arguments
> + `(#:cabal-revision
> + ("3" "1ndz5x6njl35h73il5c6qpaqd4ynvg21n6k7sb8aq09gfbg544d8")))
There's also a new arguments style:
> + (arguments
> + (list #:cabal-revision
> + (list "3"
> "1ndz5x6njl35h73il5c6qpaqd4ynvg21n6k7sb8aq09gfbg544d8")))
> + (description
> + "This library is intended to be a comprehensive solution to parsing and
> +selecting quality-indexed values in HTTP headers. It is capable of parsing
> +both media types and language parameters from the Accept and Content header
> +families, and can be extended to match against other accept headers as well.
> +Selecting the appropriate header value is achieved by comparing a list of
> +server options against the quality-indexed values supplied by the client.")
This is a wee bit too long IMO.
-- (
- [bug#44518] gnu: Add matterhorn.,
( <=