|
From: | Maxime Devos |
Subject: | [bug#57704] [PATCH v2] guix: packages: Remove #f from inputs when sanitizing. |
Date: | Sat, 10 Sep 2022 02:33:00 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 |
On 09-09-2022 17:56, Liliana Marie Prikler wrote:
This makes it so that new-style inputs can be optional using regular Guile patterns, e.g. (and (target-x86-64?) rust). * guix/packages.scm (sanitize-inputs): Filter inputs by identity before adding labels. --- As noted by Maxime, this doesn't seem to be cause any rebuilds, so retargeting master. Also added missing documentation.
The docstring is nice, but with documentation, I meant the manual, presumably in ‘(guix)package Reference’, maybe also in the packaging tutorial in the cookbook.
Also, something I forgot: performance. sanitize-inputs is called for every package, and the change adds additional memory allocations (due to the use of 'filter'), is there an observable performance impact (maybe "GUIX_PROFILING=gc time guix refresh -l pkg-config" would be a good test)? If there is, some optimisations may be in order
Greetings, Maxime.
OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
[Prev in Thread] | Current Thread | [Next in Thread] |