[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57688] [PATCH v5] gnu: Add wiggle.
From: |
( |
Subject: |
[bug#57688] [PATCH v5] gnu: Add wiggle. |
Date: |
Sat, 10 Sep 2022 00:03:02 +0100 |
Hello! :D
On Fri Sep 9, 2022 at 3:06 PM BST, jgart via Guix-patches via wrote:
> +(define-public wiggle
> + (package
^^
Unnecessary indentation here.
> + (name "wiggle")
> + (version "1.3")
> + (source
> + (origin
^^^^^^^^
Change to `(source (origin'.
> + (method git-fetch)
> + (uri
> + (git-reference
^^^^^^^^^^^^^^^
Change to `(uri (git-reference'.
> + (inputs
> + (list ncurses))
^^^^^^^
Change to `(inputs (list ...))'.
> + (arguments
> + (list #:make-flags
^
This extra indentation isn't the norm.
> + #~(list "-I. -O3"
> + (string-append "CC=" #$(cc-for-target))
> + "INSTALL=\"install\""
> + "STRIP=-s"
> + (string-append "BINDIR=" #$output "/bin")
> + (string-append "MANDIR=" #$output "/share/man")
> + (string-append "CC=" #$(cc-for-target))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Duplicate `CC' definition.
> + (string-append "PREFIX=" #$output))
> + #:phases
> + #~(modify-phases %standard-phases
> + (delete 'configure)
> + (replace 'check
> + (lambda* (#:key inputs ouputs tests? #:allow-other-keys)
^^^^^^^^^^^^^
These two are unnecessary, and the latter has a typo anyway.
> + (home-page "http://neil.brown.name/wiggle/")
> + (synopsis "Tool for applying patches with conflicts")
> + (description
> +"@code{wiggle} attempts to apply patches to a target file even if the
^^^^^^^^
Add indentation here.
-- (
- [bug#57688] [PATCH] gnu: Add wiggle., jgart, 2022/09/08
- [bug#57688] [PATCH v2] gnu: Add wiggle., jgart, 2022/09/08
- [bug#57688] [PATCH] gnu: Add wiggle., Maxime Devos, 2022/09/08
- [bug#57688] [PATCH v3] gnu: Add wiggle., jgart, 2022/09/08
- [bug#57688] [PATCH v4] gnu: Add wiggle., jgart, 2022/09/09
- [bug#57688] [PATCH v5] gnu: Add wiggle., jgart, 2022/09/09
- [bug#57688] [PATCH v5] gnu: Add wiggle.,
( <=
- [bug#57688] [PATCH v6] gnu: Add wiggle., jgart, 2022/09/09
- [bug#57688] [PATCH v7] gnu: Add wiggle., jgart, 2022/09/10
- bug#57688: [PATCH v7] gnu: Add wiggle., Liliana Marie Prikler, 2022/09/11