[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validation
From: |
Ricardo Wurmus |
Subject: |
[bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validationlayers |
Date: |
Thu, 01 Sep 2022 09:44:04 +0200 |
User-agent: |
mu4e 1.8.7; emacs 28.1 |
Thank you for the patches. Overall they look good to me, but I have
some comments:
- the first patch updates spriv-headers from 1.5.3 to 1.2.198.0. This
looks like a downgrade. Is this jump in version numbers expected?
- the commit message for the vulkan-loader update should mention the
changes in the build system arguments:
* gnu/packages/vulkan.scm (vulkan-loader): Update to 1.2.202.
[arguments]: Enable tests by removing obsolete build phase
'disable-loader-tests and adjusting configure flags.
- in the patch for vulkan-validationlayers I’d use #$output instead of
binding out to (assoc-ref outputs "out").
Other than that this all looks good to me!
--
Ricardo
- [bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validationlayers,
Ricardo Wurmus <=