guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#55663] [PATCH] Image API: add FAT32 support


From: Pavel Shlyak
Subject: [bug#55663] [PATCH] Image API: add FAT32 support
Date: Mon, 30 May 2022 12:01:27 +0300

Attachment: 0001-guix-Image-API-support-FAT32-partitions.patch
Description: Binary data


> 30 мая 2022 г., в 10:01, Mathieu Othacehe <othacehe@gnu.org> написал(а):
> 
> 
> Hello Pavel,
> 
>> gnu/build/image.scm  | 24 ++++++++++++++----------
>> gnu/system/image.scm |  9 +++++++--
> 
> Please write a commit message following the guidelines available here:
> https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
> 
>> +(define* (make-vfat-image partition target root fs_bits)
> 
> s/fs_bits/fs-bits/
> 
>> +         ((or (string=? file-system "vfat") (string=? file-system "fat16")) 
>> "0x0E")
> 
> This line is longer than 78 characters you can break it between the two
> strings comparisons.
> 
>> +         (
>> +          (or (string=? file-system "vfat")
> 
> Merge those two lines.
> 
>> +              (string=? file-system "fat32")
>> +              ) "F")
> 
> Ditto.
> 
> Can you please send a v2?
> 
> Thanks for your contribution,
> 
> Mathieu


reply via email to

[Prev in Thread] Current Thread [Next in Thread]