guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#55188] [PATCH] gnu: Add python-vitables.


From: Peter Polidoro
Subject: [bug#55188] [PATCH] gnu: Add python-vitables.
Date: Thu, 12 May 2022 10:55:57 -0400
User-agent: mu4e 1.6.10; emacs 27.2

Hi,

I have made changes you suggested to the description and have attached a new patch, thank you.

I tried to get the tests to run, but they have errors and I do not know enough yet to fix them myself:

qt.qpa.xcb: could not connect to display
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.

Is it possible to get tests like this to work when building packages in isolated environments? Or is it necessary to disable these tests?

Thank you for your time!


Mathieu Othacehe <othacehe@gnu.org> writes:

Hello Peter,

+    (arguments
+     `(#:tests? #f))

You should add a comment stating why the tests are disabled. Because
there are no tests or because they are failing, and if so why?

+ (description "ViTables is a GUI for browsing and editing files in both +PyTables and HDF5 formats. ViTables capabilities include easy navigation +through the data hierarchy, displaying of real data and its associated +metadata, a simple, yet powerful, browsing of multidimensional data and much +more. As a viewer, one of the greatest strengths of ViTables is its ability to
+display very large datasets.")
+    (license license:gpl3)))

The description could be more neutral: you could remove the "yet
powerful" and "much more" parts. The last sentence could also be
reworded: "As a viewer, ViTables is able to display very large datasets."
feels more factual.

Could you send an updated patch :) ?

Thanks,

Mathieu

Attachment: 0001-gnu-Add-python-vitables.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]