[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54852] [PATCH] gnu: Add openjdk18.
From: |
Rostislav Svoboda |
Subject: |
[bug#54852] [PATCH] gnu: Add openjdk18. |
Date: |
Wed, 11 May 2022 17:37:40 +0200 |
Hi Maxime,
> Instead, try:
>
> /home/bost/dev/guix
> # do this inside a "guix shell -D guix" or whatever you use
> # to set up a Guix development environment
> $ make && time ./pre-inst-env guix build openjdk
Ok thanks. (As you see, I need to learn a lot.)
Regarding the build time (just for the record), I run
$ cd /home/bost/dev/guix
$ git checkout dev
$ git --force -dx # make sure everything is pristine clean and clear
$ guix shell --development guix
# and then:
[env]$ ./bootstrap && ./configure --localstatedir=/var && make -j24
[env]$ time ./pre-inst-env guix build openjdk
...
real 4m32.993s
user 0m26.175s
sys 0m1.357s
And my `dev` branch contains this openjdk18 definition:
(define-public openjdk18
(package
(inherit openjdk17)
(name "openjdk")
(version "18")
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/openjdk/jdk18u")
(commit (string-append "jdk-" version "-ga"))))
(file-name (git-file-name name version))
(sha256
(base32
"1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8"))))
(native-inputs
(map (lambda (input)
(match (car input)
("openjdk16:jdk" `("openjdk17:jdk" ,openjdk17 "jdk"))
(_ input)))
(package-native-inputs openjdk17)))
(home-page "https://openjdk.java.net/projects/jdk/18")))
> > ;; I'd prefer: [...
> > (delete "openjdk16:jdk")
> > (append `(("openjdk17:jdk" ,openjdk17 "jdk"))))
>
> If/when
What do you mean by that???
> > About the labels issue: maybe "icedtea-8" could be changed to
> > "icedtea", "openjdkN" to "openjdk" and "openjdkN:jdk" to
> > "openjdk:jdk" at some point in the future, such that the package name
> > matches the input label and the input alist can be changed to a
> > package list.
>
> is addressed, WDYT of (replace "openjdk" openjdk)?
???
Could you explain that please?
Because to me, out of any context, (e.g. when grep-ing over the source
code,) that looks like a "replace a-thing with a-thing". I.e.
effectively, a do-nothing command.
Thank you.
Greetings,
Bost