[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support.
From: |
Maxime Devos |
Subject: |
[bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support. |
Date: |
Wed, 09 Feb 2022 12:05:20 +0100 |
User-agent: |
Evolution 3.38.3-1 |
Zhu Zihao schreef op wo 09-02-2022 om 10:12 [+0800]:
> + (lambda* (#:key outputs #:allow-other-keys)
Since you're doing #$output:FOO instead of (assoc-ref outputs "foo")
below now, 'outputs' is now unused, so this can be simplified to
(lambda _ ; <-- no (#:key outputs #:allow-other-keys) argument list needed
;; Take care of [...]
(define (split-immodule gtk-version output)
[...])
[...])
> + (description "Fcitx5-gtk provides following functionality in
> corresponding
As previously mentioned, a few definite articles would seem to be in place:
‘Fcitx5-gtk provides _the_ following functionality in _the_ corresponding
output:’ (emphasis mine).
Otherwise, LGTM, although I didn't test it.
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/06
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Maxime Devos, 2022/02/06
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/06
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Maxime Devos, 2022/02/06
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/06
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Maxime Devos, 2022/02/07
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/07
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Maxime Devos, 2022/02/08
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/08
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support.,
Maxime Devos <=
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/09
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Maxime Devos, 2022/02/09
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/09
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/11
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Ludovic Courtès, 2022/02/14
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/16
- [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support., Zhu Zihao, 2022/02/07