guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#52113] [PATCH] gnu: Add pnmixer


From: Jaft
Subject: [bug#52113] [PATCH] gnu: Add pnmixer
Date: Thu, 16 Dec 2021 21:40:09 +0000 (UTC)

> On Sunday, December 5, 2021, 02:43:27 PM CST, Nicolas Goaziou 
> <mail@nicolasgoaziou.fr> wrote: 
>
>
>
>
>
> Hello,
>
> Jaft <jaft.r@outlook.com> writes:
> 
> > * gnu/packages/gtk.scm (pnmixer):Add PNMixer
>
> Thank you. Some comments follow.
>
> > +(define-public pnmixer
> > +  (let ([version "0.7.2"])
>
> Nitpick: we don't use square brackets for let. Besides, you do not need
> a binding here, you just need to hard-code it in the version field.

Bah; sorry about that. It was mentioned to me, before, and I must've forgotten 
to change it before I sent this out. I probably should check my other patch 
submissions around this time as I probably forgot for those, as well…

> Could you send an updated patch?
>
> Regards,
> -- 
> Nicolas Goaziou

Thanks a ton for looking at my patch; all updates should've been applied and 
I've attached the new patch to this E-mail.

Attachment: pnmixer2.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]