[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#52030] [PATCH] gnu: Add feather font
From: |
Ludovic Courtès |
Subject: |
[bug#52030] [PATCH] gnu: Add feather font |
Date: |
Fri, 10 Dec 2021 15:28:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Jaft,
Jaft <jaft.r@outlook.com> skribis:
> * gnu/packages/fonts.scm (feather): Add Feather iconfont by AT-UI
>
> The foundry, AT-UI, has a hyphen but
> https://guix.gnu.org/manual/en/html_node/Fonts.html
> seems to implicitly imply the foundry wouldn't have hyphens so I removed them,
> for the package name (font-atui-feather).
I think it’s fine either way.
> + (name "font-atui-feather")
> + (version "0")
> + (source (origin
> + (method url-fetch/zipbomb)
> + (uri
> "https://github.com/AT-UI/feather-font/archive/refs/heads/master.zip")
> + (sha256 (base32
> "0lp1m1a47s56rj0q6nj8j5snkbw8jq3q7zwdzf86sbbglq170inh"))))
Note that ‘master.zip’ changes at each commit (and its content can also
change even if the HEAD commit is unchanged because it’s a generated
file.)
Could you instead change it to refer to a non-generated zip file, or use
‘git-fetch’ to obtain a checkout?
You may also need to adjust the version string.
> + (build-system font-build-system)
> + (home-page "https://at-ui.github.io/feather-font/")
> + (synopsis "Iconfont version of Feather")
> + (description "Feather is a collection of simply beautiful open source
> icons.
Everything is free software/data in Guix, so you can remove “open
source”. :-)
Could you send an updated patch? Preferably as a attachment to make
sure it’s not mangled on its way.
Thanks in advance!
Ludo’.
- [bug#52030] [PATCH] gnu: Add feather font,
Ludovic Courtès <=