[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#51113] [PATCH] gnu: Add snooze.
From: |
Nicolas Goaziou |
Subject: |
[bug#51113] [PATCH] gnu: Add snooze. |
Date: |
Wed, 13 Oct 2021 21:28:48 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/suckless.scm (snooze): New variable.
Thank you. Some comments follow.
> + (arguments
> + `(#:tests? #f
Could you add a comment explaining why tests are disabled? I assume
upstream does not provide any.
> + #:make-flags
> + (list (string-append "CC=" ,(cc-for-target))
> + (string-append "DESTDIR=" %output)
> + "PREFIX=")
It may be worth explaining in a comment why PREFIX is reset.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure))))
> + (home-page "https://github.com/leahneukirchen/snooze")
> + (synopsis "Run a command at a particular time")
> + (description
> +"@command{snooze} is a new tool for waiting until a particular time and then
> +running a command.")
I would remove "new" from the description.
Otherwise, LGTM. Could you send an updated patch?
Regards,
--
Nicolas Goaziou