[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#46616] [PATCH] gnu: Add python-tldr.
From: |
Tanguy LE CARROUR |
Subject: |
[bug#46616] [PATCH] gnu: Add python-tldr. |
Date: |
Sun, 06 Jun 2021 16:14:06 +0200 |
User-agent: |
astroid/0.15.0 (https://github.com/astroidmail/astroid) |
Hi Vinicius,
Thanks for reviewing this patch, and sorry for the late answer!
Excerpts from Vinicius Monego's message of May 23, 2021 11:15 pm:
> Em qui, 2021-02-18 às 15:06 +0100, Tanguy Le Carrour escreveu:
>> * gnu/packages/python-xyz.scm (python-tldr): New variable.
>> ---
>> gnu/packages/python-xyz.scm | 28 +++++++++++++++++++++++++++-
>
> [...]
>
>> +(define-public python-tldr
>> + (package
>> + (name "python-tldr")
>
> I noticed that this program is a command line tool. It should be named
> 'tldr' only and be moved to another file. Perhaps to man.scm?
Your suggestions make sense, but there's another `tldr` client.
Namely `ghc-tldr`. It's defined in `gnu/packages/haskell-xyz.scm`.
If it's okay with you, I'll leave `python-tldr` in
`gnu/packages/python-xyz.scm`.
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (pypi-uri "tldr" version))
>> + (sha256
>> + (base32
>> + "00h43xjrzrayy1gysvmql5kfabk2d8xraih68d41616brdvb1xvf"))))
>> + (build-system python-build-system)
>> + (native-inputs
>> + `(("python-pytest" ,python-pytest)
>> + ("python-pytest-runner" ,python-pytest-runner)))
>
> The tests for this one are not distributed in the PyPI release. Could
> you source from the homepage instead?
>
> There is one test that tries to open a network connection, it will have
> to be skipped.
Done.
>
>> + (propagated-inputs
>> + `(("python-argcomplete" ,python-argcomplete)
>> + ("python-colorama" ,python-colorama)
>> + ("python-termcolor" ,python-termcolor)))
>
> If it is only a command line tool, inputs should be normal inputs here.
Done.
>> + (description "This package provides the `tldr' command allowing
>> users
>> +to view `tldr' pages from a shell. The `tldr' pages are a community
>> effort
>> +to simplify the man pages with practical examples.")
>
> The linter made this complaint for the description: "use @code or
> similar ornament instead of quotes".
Done.
The new patch is following in another email…
Regards,
--
Tanguy
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#46616] [PATCH] gnu: Add python-tldr.,
Tanguy LE CARROUR <=