[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48630] [PATCH] adds `ack' package and it's perl module dependency F
From: |
Maxime Devos |
Subject: |
[bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next |
Date: |
Mon, 24 May 2021 23:01:09 +0200 |
User-agent: |
Evolution 3.34.2 |
Gabriel Wicki schreef op ma 24-05-2021 om 21:10 [+0200]:
> [...]
> +(define-public ack
> + (package
> + (name "ack")
> + (version "3.5.0")
> + (source (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/beyondgrep/ack3")
> + (commit (format #nil "v~a" version))))
#f is an elisp compatibility hack in Guile.
Use (format #f "v~a" version) instead, or simpler
(string-append "v" version).
Looking at the patch only and (I didn't test it, didn't do
licensing checks, etc.) I only see one other problem:
> + (arguments '(#:tests? #f))
Why are the tests disabled? (Are there none, do they need
additional packages not in Guix, ...) Maybe add a line like
> + ;; There is no test suite.
> + (arguments '(#:tests? #f))
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part