[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48220] [PATCH] gnu: xfce4-session: Add xset to propagated-inputs.
From: |
Brendan Tildesley |
Subject: |
[bug#48220] [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. |
Date: |
Thu, 6 May 2021 04:38:58 +0200 (CEST) |
> On 05/05/2021 3:23 PM Ludovic Courtès <ludo@gnu.org> wrote:
>
>
> Hi Brendan,
>
> Brendan Tildesley <mail@brendan.scot> skribis:
>
> > * gnu/packages/xfce.scm (xfce4-session):[propagated-inputs]: Add xset so
> > that xflock4 can turn off the monitor.
>
> Can’t we instead patch ‘scripts/xflock4’ so that it refers to ‘xset’ by
> its absolute file name?
>
I can. It felt weird just patching one command and not others though.
> However, my understanding is that the xset code is already a fallback:
>
> --8<---------------cut here---------------start------------->8---
> # else run another access locking utility, if installed
> for lock_cmd in \
> "xlock -mode blank" \
> "slock"
> do
> set -- $lock_cmd
> if command -v -- $1 >/dev/null 2>&1; then
> $lock_cmd >/dev/null 2>&1 &
> # turn off display backlight:
> xset dpms force off
> exit
> fi
> done
> --8<---------------cut here---------------end--------------->8---
>
> Probably we should ensure the first ‘for’ loop works as expected.
> Perhaps we need to replace ‘xfce4-screensaver-command’ by its absolute
> file name there.
>
Currently xfce4-screensaver is not installed in the xfce package at all by
default,
so it isn't used. I could add it, but for me it was glitchy/flickering and I
would keep
clearing the password as I was entering it so I couldn't log back in. It even
does it
in a VM. I do have a recent amd graphics card with proprietary linux though, my
computer
can't boot otherwise :(.
If you run guix environment --ad-hoc xfce4-screensaver
then
xfce4-screensaver &; xfce4-screensaver-command --lock
does it work for you?
I'm not sure what is best, should we be maximal and include xfce4-screensaver
in the xfce
package, or be minimal and make people have to install it manually?
> WDYT?
>
> Thanks,
> Ludo’.
0001-gnu-xfce4-session-Add-xset-to-propagated-inputs.patch
Description: Text Data
0001-gnu-xfce4-session-Allow-xflock4-to-use-xset.patch
Description: Text Data