[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46620: Fixed git patch
From: |
Nicolas Goaziou |
Subject: |
bug#46620: Fixed git patch |
Date: |
Thu, 18 Feb 2021 21:07:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
Юрий Холодков <urist.mckorobochka@gmail.com> writes:
> Subject: [PATCH] gnu: emacs-kbd: new package
I committed your patch with the minor changes detailed below.
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'enter-lisp-directory (lambda _ (chdir
> "lisp") #t)))))
I moved the lambda on the line below.
> + (synopsis "Emacs minor mode for syntax highlighting kmonad's .kbd
> files.")
I slightly shortened synopsis and used @file{.kbd}.
> + (description
> + "This minor mode provides syntax highlighting for Lisp-like DSL
> used in kmonad's
> +configuration files (.kbd). It inherits from `emacs-lisp-mode' to provide
> sensible
> +parenthesis handling.")
I removed the second sentence in description, since it is not so useful
when trying to explain what the library is about. I also used
@file{.kbd}.
I added a copyright line for you at the top of the "emacs-xyz.scm" file.
I also added an appropriate commit message.
Note that your patch didn't apply cleanly. You may use "git
format-patch". If you did, something else broke your patch somehow.
Thanks!
Regards,
--
Nicolas Goaziou