[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45712: [PATCHES] Improve Python package quality
From: |
Maxim Cournoyer |
Subject: |
bug#45712: [PATCHES] Improve Python package quality |
Date: |
Mon, 01 Feb 2021 12:02:44 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Lars,
Lars-Dominik Braun <lars@6xq.net> writes:
> Hi Maxim,
>
>> Oh yes, sorry I had failed to mention it, this is on the
>> cu/farewell-to-pythonpath branch, which is the integration of
>> GUIX_PYTHONPATH and this work of yours. I've included your v2 patches,
>> with light editing: fixed the script indentation (spot via flake8), I
>> removed the python2 tests as Python 2 is obsolete, and removed the space
>> between the (procedure)[area/conditional] part of the GNU changelog
>> commit messages.
> thanks!
>
>> Another note to help with review; when sending v2 patches, make sure the
>> title of your mail reply mentions [PATCH v2]; this helps to spot the
>> later versions in email threads.
> Sorry about that, will do next time.
>
>> The branch is shaping up nicely; I encourage you to try it. If no major
>> problem is found with it, I'll merge it in core-updates soon.
> I’ve been rebuilding packages on my list that use python-build-system
> using this branch and quite a few fail, but in a random sample I found
> none that fails due to this patch and also I imagine some issues are
> already fixed on core-updates? Is there anything else I can do?
I guess we can be bold and merge the branch to core-updates, and fix any
breakage that may occur there!
I've done so, the last commit of the series is
1b9186828867e77af1f2ee6741063424f8256398.
Let's make Python on Guix great again!
Thank you :-)
Closing,
Maxim