guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#44039] [PATCH] gnu: Add slade.


From: Ludovic Courtès
Subject: [bug#44039] [PATCH] gnu: Add slade.
Date: Wed, 28 Oct 2020 15:54:31 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hi,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> The following made multiple builds on one machine identical, but was
> not consistent between file systems, probably due to readdir order:
>
> + (add-before 'build 'reset-slade.pk3-timestamps
> +   ;; This appears sufficient to make slade.pk3 reproducible.
> +   (lambda _
> +     (invoke "find" "../source/dist/res" "-exec" "touch"
> +             "--no-dereference" "-t" "197001010000.00" "{}" "+")))

It’s surprising that this is necessary because the ‘unpack’ phase copies
the source directory preserving the mtime of files and since those files
are in the store, their mtime is 1:

        ;; Preserve timestamps (set to the Epoch) on the copied tree so that
        ;; things work deterministically.
        (copy-recursively source "."
                          #:keep-mtime? #t)

Thoughts?

Anyhow, we can probably push v2.

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]