[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43809] [PATCH 1/1] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b.
From: |
zimoun |
Subject: |
[bug#43809] [PATCH 1/1] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b. |
Date: |
Fri, 9 Oct 2020 00:28:39 +0200 |
Hi Nicolas,
Thank you for the review. The v2 is sent.
<http://issues.guix.gnu.org/43809#3>
On Wed, 7 Oct 2020 at 21:43, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> > + (let ((commit "ccde45bbc292123ec20617f1af7f7e19f7481545"))
>
> I suggest to add a comment explaining why we do not use regular release.
Done but I was not very inspired. :-)
> > + (native-inputs `(("emacs" ,emacs-minimal)
> > + ("opam" ,opam)))
>
> Nitpick: Please move these inputs below `native-inputs'.
Thank you for the nitpick. Done. To be honest, I am not tweaked this line. :-)
Cheers,
simon
- [bug#43809] [PATCH 0/1] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., zimoun, 2020/10/05
- [bug#43809] [PATCH 1/1] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., zimoun, 2020/10/05
- [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., zimoun, 2020/10/08
- [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., Nicolas Goaziou, 2020/10/13
- [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., zimoun, 2020/10/13
- [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., Nicolas Goaziou, 2020/10/13
- [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., zimoun, 2020/10/13
- [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., zimoun, 2020/10/19
- [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., Nicolas Goaziou, 2020/10/19
- [bug#43809] [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., zimoun, 2020/10/19
- bug#43809: [PATCH v2] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b., Nicolas Goaziou, 2020/10/19