[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43494] [PATCH v2 4/4] services: guix: Add guix-build-coordinator-qu
From: |
Ludovic Courtès |
Subject: |
[bug#43494] [PATCH v2 4/4] services: guix: Add guix-build-coordinator-queue-builds-service-type. |
Date: |
Mon, 05 Oct 2020 10:00:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Chris,
Sorry for the delay. Patches 1–3 LGTM! One minor comment on patch 4:
Christopher Baines <mail@cbaines.net> skribis:
> * gnu/services/guix.scm (<guix-build-coordinator-queue-builds-configuration>):
> New record type.
> (guix-build-coordinator-queue-builds-configuration,
> guix-build-coordinator-queue-builds-configuration?,
> guix-build-coordinator-queue-builds-configuration-package,
> guix-build-coordinator-queue-builds-configuration-user,
> guix-build-coordinator-queue-builds-coordinator,
> guix-build-coordinator-queue-builds-configuration-systems,
> guix-build-coordinator-queue-builds-configuration-system-and-targets,
> guix-build-coordinator-queue-builds-configuration-guix-data-service,
> guix-build-coordinator-queue-builds-configuration-processed-commits-file,
> guix-build-coordinator-queue-builds-shepherd-services,
> guix-build-coordinator-queue-builds-activation,
> guix-build-coordinator-queue-builds-account): New procedures.
> (guix-build-coordinator-queue-builds-service-type): New variable.
[...]
>
> +@defvar {Scheme Variable} guix-build-coordinator-queue-builds-service-type
> +Service type for the
> +guix-build-coordinator-queue-builds-from-guix-data-service script. Its
> +value must be a @code{guix-build-coordinator-queue-builds-configuration}
> +object.
> +@end defvar
Could you add a paragraph right above this explaining what this service
is about?
> +(define guix-build-coordinator-queue-builds-service-type
> + (service-type
> + (name 'guix-build-coordinator-queue-builds)
> + (extensions
> + (list
> + (service-extension shepherd-root-service-type
> +
> guix-build-coordinator-queue-builds-shepherd-services)
> + (service-extension activation-service-type
> + guix-build-coordinator-queue-builds-activation)
> + (service-extension account-service-type
> + guix-build-coordinator-queue-builds-account)))
> + (description
> + "Run the Guix Build Coordinator queue builds script.")))
Likewise it’d be great if you could add a few works here.
OK to push with these changes, thank you!
Ludo’.
- [bug#43494] [PATCH v2 4/4] services: guix: Add guix-build-coordinator-queue-builds-service-type.,
Ludovic Courtès <=