guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#43119] [PATCH] gnu: Add guile-srfi-180.


From: Martin Becze
Subject: [bug#43119] [PATCH] gnu: Add guile-srfi-180.
Date: Mon, 31 Aug 2020 04:11:15 -0500

>> Do you think they could be fixed?

Fixed in the attached patch.

> Even though this description is a copy of the SRFI abstract, it seems a
> bit vague. I would change "describes" to "implements" or "provides". The
> affirmation "JSON bigger than memory" could also be expanded I think.

I tried to spruce it up a bit. Thanks for the feedback!

On 8/31/20 3:14 AM, Mathieu Othacehe wrote:

Hey,

* gnu/packages/guile-xyz.scm (guile-srfi-180): New variable.

I'm getting a whole bunch of warnings when building srfi/180/body.scm,
such as:

--8<---------------cut here---------------start------------->8---
srfi/180/body.scm:237:11: warning: possibly unbound variable `textual-port?'
srfi/180/body.scm:198:4: warning: possibly unbound variable `eof-object'
srfi/180/body.scm:195:2: warning: possibly unbound variable `assume'
srfi/180/body.scm:191:23: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:190:29: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:186:16: warning: possibly unbound variable `valid-number?'
srfi/180/body.scm:167:29: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:146:59: warning: possibly unbound variable `bitwise-ior'
srfi/180/body.scm:111:15: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:106:15: warning: possibly unbound variable `make-json-error'
--8<---------------cut here---------------end--------------->8---

Do you think they could be fixed?

+       "This library describes a JavaScript Object Notation (JSON) parser and 
printer.
+It supports JSON that may be bigger than memory.")

Even though this description is a copy of the SRFI abstract, it seems a
bit vague. I would change "describes" to "implements" or "provides". The
affirmation "JSON bigger than memory" could also be expanded I think.

Thanks,

Mathieu

Attachment: v2-0001-gnu-Add-guile-srfi-180.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]