[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43101] [PATCH v2] Add version number in release ISO
From: |
Mathieu Othacehe |
Subject: |
[bug#43101] [PATCH v2] Add version number in release ISO |
Date: |
Mon, 31 Aug 2020 08:18:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hey Julien,
Thanks for the v2 :)
> (inherit iso9660-image)
> - (operating-system installation-os))))
> + (operating-system installation-os)
> + (partitions (match (image-partitions iso9660-image)
> + ((boot others ...)
> + (cons
> + (partition
> + (inherit boot)
> + (label (string-append "GUIX_" system "_"
> + %guix-version)))
> + others)))))))
We could maybe factorize this in something like:
--8<---------------cut here---------------start------------->8---
(define (image-with-label image label)
...)
--8<---------------cut here---------------end--------------->8---
that would be put in (gnu system image).
Otherwise, looks fine to me :)
Thanks again,
Mathieu