[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42650: [PATCH 2/2] gnu: Add python-onnx.
|
From: |
Mathieu Othacehe |
|
Subject: |
bug#42650: [PATCH 2/2] gnu: Add python-onnx. |
|
Date: |
Mon, 03 Aug 2020 09:05:40 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
A few comments on this one.
> * gnu/packages/machine-learning.scm (python-onnx): New variable.
You need to mention the added file in the commit message and also add it
to gnu/local.mk.
> + ;; ONNX will build googletest from a git checkout. Patch CMake
> + ;; to use googletest from Guix and enable tests by default.
That seems to be a recurrent issue. Did you fix it by yourself or is
there a patch out there?
Otherwise both patches look fine. I fixed the patch registering thing
and pushed.
Thanks,
Mathieu