[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41541] [PATCH 7/8] services: hurd: Add `hurd-etc-service'.
From: |
Ludovic Courtès |
Subject: |
[bug#41541] [PATCH 7/8] services: hurd: Add `hurd-etc-service'. |
Date: |
Sun, 07 Jun 2020 22:02:05 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi,
Jan Nieuwenhuizen <janneke@gnu.org> skribis:
> From 4cef6e73ce9fd137640c1c00f98958cdc41dda90 Mon Sep 17 00:00:00 2001
> From: "Jan (janneke) Nieuwenhuizen" <janneke@gnu.org>
> Date: Sat, 25 Apr 2020 11:55:56 +0200
> Subject: [PATCH] services: Support etc-service for the Hurd.
>
> * gnu/system.scm (operating-system-etc-service): Cater for missing nsswitch
> and missing sudoers-file. For the Hurd, add "login" and "motd".
> (hurd-default-essential-services): Add operating-system-etc-service.
Perfect!
[...]
> + ,@(if sudoers `(("sudoers" ,sudoers)) '())
> + ,@(if hurd `(("login" ,(file-append hurd "/etc/login"))
> + ("motd" ,(file-append hurd "/etc/motd"))))))))
We’re missing the ‘else’ branch here.
Apart from that, LGTM!
Thank you,
Ludo’.