[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41395] [PATCH 2/2] gnu: Add python-questionary
From: |
Edouard Klein |
Subject: |
[bug#41395] [PATCH 2/2] gnu: Add python-questionary |
Date: |
Mon, 25 May 2020 13:23:00 +0200 |
User-agent: |
mu4e 1.4.6; emacs 26.3 |
Marius Bakke writes:
> Edouard Klein <address@hidden> writes:
>
>> * /gnu/packages/python-xyz.scm (python-questionary): New variable
>> * /gnu/packages/python-check.scm (python-pytest-pycodestyle): New variable
>
> Can you submit these packages as two separate patches?
>
> [...]
>
Done
>> +(define-public python-pytest-pycodestyle
>> + (package
>> + (name "python-pytest-pycodestyle")
>> + (version "2.0.0") ;; Any version higher than that requires
>> python-pytest~=5.4
>> + ;; (python-pytest is at version 5.3.5 as I write this comment
>> + ;; and 5478 packages depend on it.)
>
> You can create a 'python-pytest-5.4' variable instead of sticking to
> this old version, we'll probably need it sooner or later. No strong
> opinion though.
>
I did not understand that pinning dependencies was also allowed for
future versions. I tried but I can't get python-pytest 5.4's tests to
pass, so I'll leave it like that for now and try to come back and
revisit that if I have some time.
> [...]
>
>> +(define-public python-questionary
>> + (package
>> + (name "python-questionary")
>> + (version "1.5.2")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (pypi-uri "questionary" version))
>> + (sha256
>> + (base32
>> + "09n737qmvzbibl8hmbd5zfg1502fd9n0r8qjzz1y0vy8nqv1xr7n"))))
>> + (build-system python-build-system)
>> + (propagated-inputs
>> + `(("python-prompt-toolkit" ,python-prompt-toolkit)))
>> + (native-inputs
>> + `(("python-coveralls" ,python-coveralls)
>> + ("python-pytest-cov" ,python-pytest-cov)
>> + ("python-pytest-pycodestyle"
>> + ,python-pytest-pycodestyle)
>> + ))
>
> These parens feel lonely. :-)
I did a last minute edit and forgot to lint again, sorry :)
>
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (replace 'check
>> + (lambda _
>> + (invoke "py.test"))))))
>> + (home-page "https://github.com/tmbo/questionary")
>> + (synopsis
>> + "Pretty command line user prompts")
>
> The line break here is not necessary.
>
> LGTM with these changes, can you send updated patches?
>
> Thanks!
Thank you for reviewing the changes and for the suggestions :)
[bug#41395] [PATCH 2/2] gnu: Add python-questionary, Edouard Klein, 2020/05/19
[bug#41395] [PATCH 1/4] gnu: Update python-iml homepage to https, Edouard Klein, 2020/05/25
[bug#41395] [PATCH 2/4] gnu: Update python-prompt-toolkit to version 3.0.5, Edouard Klein, 2020/05/25
[bug#41395] [PATCH 3/4] gnu: Add python-pytest-pycodestyle, Edouard Klein, 2020/05/25
[bug#41395] [PATCH 4/4] gnu: Add python-questionary, Edouard Klein, 2020/05/25
[bug#41395] [PATCH 1/3] gnu: Update python-widgetsnbextension to 3.5.1, Edouard Klein, 2020/05/26