[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41431] [PATCH] gnu: Add protonvpn-cli.
From: |
Ryan Prior |
Subject: |
[bug#41431] [PATCH] gnu: Add protonvpn-cli. |
Date: |
Sat, 23 May 2020 19:11:18 +0000 |
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, May 23, 2020 2:17 PM, Ludovic Courtès <address@hidden> wrote:
> there are definitely tests
What makes you so sure? `grep -r '\Wtest' .` suggests that the only reference
to testing in the whole repo is in protonvpn_cli/utils.py (wait_for_network)
which tests for a network connection at runtime. I don't think they are
shipping any tests; setup.py can test to make sure you can actually install
your dependencies, but that's not a meaningful upstream test, it's a default
behavior.
> > - (license license:gpl3)))
>
> This is ‘gpl3+’ AFAICS since nothing says “version 3 only.”
Nothing says "or any later version" either—I had been under the impression that
the "plus" was opt-in, but reading GPLv3 again it appears to be opt-out. I
don't know, that's not my area of expertise. I've updated the patch to gpl3+
with your recommendation in any case.
> Could you send an updated patch?
>
> Bonus points if you expound the description a bit. :-)
Of course! Here you go.
Thanks,
Ryan
0001-gnu-Add-protonvpn-cli.patch
Description: Text Data