[bug#41193] [PATCH 00/13] Update network-manager suite

[Brice Waegeneire]

Hello Leo,

On 2020-05-12 21:36, Leo Famulari wrote:
> On Tue, May 12, 2020 at 09:12:33PM +0000, Brice Waegeneire wrote:
> > On 2020-05-11 20:05, Leo Famulari wrote:
> > > I think there are some Guix system tests that should exercise
> > > NetworkManager. Can you check if they still pass?
> >
> > I can't find the test in question, can you give me a hint were they
> > should be?
>
> The system tests are found in 'gnu/tests'.
>
> I know that %desktop-services (from 'gnu/services/desktop.scm') uses
> NetworkManager, so I grepped in 'gnu/tests' for %desktop-services, and
> found that some of the system installation tests use %desktop-services.
>
> Specifically, I think that the system test
> 'gui-installed-desktop-os-encrypted' should exercise NetworkManager:
>
> `make check-system TESTS=gui-installed-desktop-os-encrypted`
>
> It's not a hard requirement to run these tests IMO, especially since 
> you
> are already using these patches successfully, but it's at least helpful
> to say if you tried or not.

I tired running the test but even on master it fails, CI can't built it
either. But trying to built it with my patches I manage to find 2 gnome
packages that broke because of it: they were looking for libnma in
network-manager-applet which isn't included with it anymore. There 
aren't
any other packages directly depending on network-manager-applet so there
shouldn't be any other breakage relating to this specific issue.

sirmacik tested the patchset too and used the vpnc plugin fine but as me
he is not a user of the applet. Should we wait for the test to be fixed,
before going forward with this patchset?

I'm sending the v2 shortly.

Cheers,
- Brice