[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41380] [PATCH] gnu: add glabels
From: |
Nicolas Goaziou |
Subject: |
[bug#41380] [PATCH] gnu: add glabels |
Date: |
Wed, 20 May 2020 20:07:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Vinicius Monego <address@hidden> writes:
> ---
> gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
Thank you! Could you use "git format-patch" and provide a commit message
in line with what we usually do for new packages? You may want to check
the commits in the repository to get an idea.
> +(define-public glabels
> + (package
> + (name "glabels")
> + (version "3.4.1")
> + (source (origin
Nitpick: Could you move "(origin" on the next line?
> + (method url-fetch)
> + (uri (string-append "mirror://gnome/sources/" name "/"
> + (version-major+minor version) "/"
> + name "-" version ".tar.xz"))
Could you replace "name" with "glabels"? We do not hard-code names
anymore in package definitions.
> + (sha256
> + (base32
> + "0f2rki8i27pkd9r0gz03cdl1g4vnmvp0j49nhxqn275vi8lmgr0q"))))
Nitpick: Could you put the string on the same line as `base32'?
> + (build-system glib-or-gtk-build-system)
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("glib:bin" ,glib "bin")
> + ("gettext" ,gettext-minimal)
> + ("intltool" ,intltool)
> + ("itstool" ,itstool)))
Could you re-order alphabetically the native inputs?
> + (inputs
> + `(("gtk+" ,gtk+)
> + ("librsvg" ,librsvg)
> + ("libxml2" ,libxml2)))
> + (home-page "http://glabels.org/")
The home-page should be using https
> + (synopsis "Program for creating labels and business cards.")
Synopsis shouldn't end with a full stop. You may want to lint your
package definition with "guix lint".
> + (description
> + "gLabels is a program for creating labels and business cards. It is
> +designed to work with various laser/ink-jet peel-off label and business
> +card sheets that you’ll find at most office supply stores.")
> + (license license:gpl3+)))
Could you send an updated patch?
Regards,
--
Nicolas Goaziou