[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu,
From: |
Mathieu Othacehe |
Subject: |
[bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd. |
Date: |
Tue, 19 May 2020 11:14:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello Janneke,
> + #$(if (hurd-target?)
> + #~#+(grub-root-search store-device font-file)
> + (grub-root-search store-device font-file))
> + #$(if (hurd-target?)
> + #~#+(setup-gfxterm config font-file)
> + (setup-gfxterm config font-file))
I'm not certain that hurd-target? always return the expected answer
here. Now that we have let-system, the safer way to check for the target
system could be to write:
--8<---------------cut here---------------start------------->8---
#$(let-system (system target)
(hurd-target? system target))
--8<---------------cut here---------------end--------------->8---
Ludo, is this correct? Furthermore, if you make sure that
"grub-root-search" and "setup-gfxterm" return #+, you could maybe drop
this part?
> +
> + (loader #$(if (hurd-target?) #~#+loader loader))
> + (linux #$(if (hurd-target?)
> + #~(string-append
> + #+linux "/"
> + #+(system-linux-image-file-name))
> + #~(string-append
> + #$linux "/"
> + #$(system-linux-image-file-name))))
Same concern as above about "hurd-target?".
> + ;; (if #$(hurd-target?)
> + ;; '#+(append (list parted e2fsprogs dosfstools)
> + ;; (map canonical-package
> + ;; (list sed grep coreutils
> findutils gawk)))
> + ;; '#$(append (list parted e2fsprogs dosfstools)
> + ;; (map canonical-package
> + ;; (list sed grep coreutils findutils
> gawk))))
> + )
Is this needed?
Thanks,
Mathieu
- [bug#41350] [PATCH 3/3] system: vm: Build vm-image using native qemu., (continued)
[bug#41350] [PATCH v2 1/3] utils: Move 'reset-timestamps' out of database., Jan (janneke) Nieuwenhuizen, 2020/05/19
- [bug#41350] [PATCH v2 2/3] system: vm: Do not register-closures when cross-building to the Hurd., Jan (janneke) Nieuwenhuizen, 2020/05/19
- [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Jan (janneke) Nieuwenhuizen, 2020/05/19
- [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd.,
Mathieu Othacehe <=
- [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Ludovic Courtès, 2020/05/20
- [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Jan Nieuwenhuizen, 2020/05/23
- [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Mathieu Othacehe, 2020/05/23
- [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Jan Nieuwenhuizen, 2020/05/23
- [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Mathieu Othacehe, 2020/05/24
- [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Ludovic Courtès, 2020/05/27
- [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Mathieu Othacehe, 2020/05/28
[bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Jan Nieuwenhuizen, 2020/05/24
[bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Mathieu Othacehe, 2020/05/24
[bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd., Jan Nieuwenhuizen, 2020/05/24