[bug#41294] [PATCH] gnu: Add libfreenect.

[宋文武]

Ekaitz Zarraga <address@hidden> writes:

> Hi,

Hello,
>
> Adding libfreenect as discussed here:
>
> https://issues.guix.gnu.org/40492
>
> I have some doubts with this package:
>
> - It has some extra flags that can be set in the configure step to build some 
> python bindings. I didn't set them because they also require a python 
> interpreter. How is the best way to handle that? Make another package with 
> the flags set? Activate them by default? Leave them as I did?

We generally try to enable all optional features when adding a package,
I'd go with:

  1. Build the python bindings by default.

  2. Try seperate the python bindings into another output.  (eg: newt)

  3. If 1 and 2 seems difficult, try add a seperate package for the
  python bindings, and it better only contains the bindings, reuse the
  original package as input.  (eg: python-libxml2)

  4. If not feel lucky, just leave a TODO comment for it...


>
> - The package is 300 megs checking `guix size` that's because it has some 
> testing binaries that have extra dependencies. If only the library is 
> compiled it doesn't depend on GLUT and that reduces the size a lot. I tried 
> to separate the package's outputs but I don't know how to do it correctly (I 
> checked the docs but it doesn't go in detail). I'd like to do it but I need 
> some help.

To define a packages with multiple outputs:

- Decide what ‘outputs’ can be made, eg: ‘doc’, ‘bin’, ‘examples’,
  etc.  In this case, I’d add an ‘examples’ output, to put those
  ‘freenect-*’ binaries, built from the “examples” directory.
  
- Add an ‘outputs’ field, it default to ‘(list "out")’, We’d use
  ‘(outputs '("out" "examples")’.

- Modify the install flags or phases to get files into their output
  directory.  Sometimes we can configure the target directory by flags,
  but usually we have to move the files around after the install phase…
  
You can see ‘newt’ in ‘gnu/packages/slang.scm’ for a example.  

>
> - I'm not sure if the file where I added it is a good choice.

Same here, we can always move it later…

>
> Best,
>
> Ekaitz
>
> ---
>
>>From aa74e0b4872f6a2748ed919ebe3c265472d04664 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <address@hidden>
> Date: Fri, 15 May 2020 23:22:04 +0200
> Subject: [PATCH] gnu: Add libfreenect.
>
>     * gnu/packages/libusb (libfreenect): New variable.
> ---
>  gnu/packages/libusb.scm | 39 ++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm
> index 3842f3fead..a27373c15a 100644
> --- a/gnu/packages/libusb.scm
> +++ b/gnu/packages/libusb.scm
> @@ -10,6 +10,7 @@
>  ;;; Copyright © 2018 Vagrant Cascadian <address@hidden>
>  ;;; Copyright © 2020 Marius Bakke <address@hidden>
>  ;;; Copyright © 2020 Christopher Howard <address@hidden>
> +;;; Copyright © 2020 Ekaitz Zarraga <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -48,7 +49,8 @@
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages python-xyz)
>    #:use-module (gnu packages tls)
> -  #:use-module (gnu packages xiph))
> +  #:use-module (gnu packages xiph)
> +  #:use-module (gnu packages gl))
>
>  (define-public libusb
>    (package
> @@ -679,3 +681,38 @@ HID-Class devices.")
>
>  (define-public python2-hidapi
>    (package-with-python2 python-hidapi))
> +
> +(define-public libfreenect
> +  (let ((version "0.6.1"))
> +    (package
> +      (name "libfreenect")
> +      (version version)
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/OpenKinect/libfreenect";)
> +                      (commit (string-append "v" version))))
> +                (sha256
> +                 (base32 
> "0was1va167rqshmpn382h36yyprpfi9cwillb6ylppmnfdrfrhrr"))))
> +      (build-system cmake-build-system)
> +      (arguments
> +       `(#:tests? #f ;; Project has not tests
This ` quasiquote is unnecessary here, a ' quote is enough, because we
refer nothing outside in the arguments list.

By convention, a single semicolon is for comment after expression in the
same line. a double semicolon is for comment the next lines.

> +         #:phases
> +         (modify-phases %standard-phases
> +           (add-after 'install 'install-udev-rules
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let* ((out (assoc-ref outputs "out"))
> +                      (rules-out (string-append out "/lib/udev/rules.d")))
> +                 (install-file 
> "../source/platform/linux/udev/51-kinect.rules"
> +                               (string-append rules-out "51-kinect.rules"))
> +                 #t))))))
> +      (native-inputs
> +       `(("libusb" ,libusb)
> +         ("pkg-config" ,pkg-config)))
> +      (inputs
> +       `(("glut" ,freeglut)))
> +      (synopsis "Drivers and libraries for the Xbox Kinect device")
> +      (description "libfreenect is a userspace driver for the Microsoft 
> Kinect.
> +It supports: RGB and Depth Images, Motors, Accelerometer, LED and Audio.")
> +      (home-page "https://openkinect.org/";)
> +      (license license:gpl2+))))
> --
> 2.26.1

Otherwise, look goods to me, hope it helps!