[bug#41053] [PATCH 1/2] gnu: Add ableton-link.

[goodoldpaul]

Hi Marius,

> > +    (arguments
> > +     `(#:configure-flags
> > +       '("-DBUILD_TYPE=Release"
>
> You can use #:build-type instead of passing -DCMAKE_BUILD_TYPE.  Is
> there a particular reason why the default "RelWithDebInfo" does not cut
> it?

It's just because I read on CMake's website that it's supposed to enable 
"-O3" flags, but I'm no expert. Also, reading further, it seems that too 
much aggressive optimizations can sometimes break software. For now I 
removed it and if there will ever be the need it can be easily 
reinstated.

> > +                                                "-checkout/")))
> > +               (substitute* (string-append source
> > +                                           
> > "cmake_include/AsioStandaloneConfig.cmake")
>
> Note: if you run this phase immediately after 'unpack, you don't have 
> to
> add a binding for the source directory as you can refer to this file by
> just (substitute* "cmake_include/AsioStandaloneConfig.cmake").  But
> perhaps that will break things?

Yes sadly it does, because it makes CMake think that the headers will be 
in "../../../include" while they are at the same level.

> > +               (for-each (lambda (test-file)
> > +                           (delete-file test-file))
> > +                         '("bin/LinkDiscoveryTest" 
> > "bin/LinkCoreTest"))
> > +               (copy-recursively "bin" bin)
> > +               (copy-recursively (string-append source 
> > "/include/ableton")
> > +                                 (string-append out 
> > "/include/ableton"))
> > +               (install-file (string-append source 
> > "/AbletonLinkConfig.cmake")
> > +                             lib-cmake)
> > +               (install-file (string-append source
> > +                                            
> > "/cmake_include/AsioStandaloneConfig.cmake")
> > +                             (string-append lib-cmake 
> > "/cmake_include"))
>
> Terrible that we have to install "manually" here!  But oh well.

Yes it is, upstream seems to not provide a "make install" target :(

> > diff --git 
> > a/gnu/packages/patches/ableton-link-system-libraries-debian.patch 
> > b/gnu/packages/patches/ableton-link-system-libraries-debian.patch
> > new file mode 100644
> > index 0000000000..0c12c62546
> > --- /dev/null
> > +++ b/gnu/packages/patches/ableton-link-system-libraries-debian.patch
> > @@ -0,0 +1,27 @@
> > +Description: Drop dependencies on included 3rd-party libs
> > + upstream includes git-submodules for Catch and ASIO (not found in 
> > the tarball).
> > + on Debian we want to use the system provided libraries.
> > +Author: IOhannes m zmölnig
> > +Origin: Debian
> > +Forwarded: not-needed
> > +Last-Update: 2016-10-26
> > +---
> > +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
>
> Great that you took care to unbundle dependencies.  Can you add a link
> to where you found this patch?

I got it from Debian's package, I now added a link in the patch header.

Thanks for your patience,

Giacomo