guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40970] [PATCH] gnu: add emacs-boon


From: Nicolas Goaziou
Subject: [bug#40970] [PATCH] gnu: add emacs-boon
Date: Fri, 01 May 2020 22:49:09 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello,

Elais Player <address@hidden> writes:

> This patch adds the emacs-boon package with changes recommended by
> Nicolas Goaziou.

Thank you.

> +    (description
> +     "Boon is a complete package for modal editing, which is not Evil.
> +Strong points:

Nitpick: I suggest to use a complete sentence here.

> +@itemize
> +@item Ergonomic: common commands are easy to type.
> +@item Emacs-friendly: Emacs conventions are respected as much as compatible
> +with design goals. This means that Boon integrates well with existing Emacs
> +infrastructure, and leverages it. Existing user configuration can often be
> +re-used.
> +@item Modular: No need to buy into the whole system: mix-and-match the parts

"No need" -> "no need"

Also, you need to put two spaces at the end of sentences in description.

Otherwise, LGTM.

You generated a new patch on top of the previous one. Could you merge
both, fix the above, and send one last patch?

Regards,

-- 
Nicolas Goaziou





reply via email to

[Prev in Thread] Current Thread [Next in Thread]