[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40980] gnu: xfe: Fix configuration and icons. (v3)
From: |
Raghav Gururajan |
Subject: |
[bug#40980] gnu: xfe: Fix configuration and icons. (v3) |
Date: |
Fri, 1 May 2020 10:41:29 -0400 |
Hi Danny!
> > * gnu/packages/disk.scm (xfe): Fix configuration and icons.
>
> Please mention the phases and arguments you changed.
>
> > (origin
> > (method url-fetch)
> > (uri
> > - (string-append "https://sourceforge.net/projects/xfe/files/xfe/"
> > - version
> > - "/xfe-" version ".tar.gz"))
> > + (string-append "https://sourceforge.net/projects/" name "/files/"
> > name
> > + "/" version "/" name "-" version ".tar.gz"))
>
> Please don't do that without a good reason because it makes us unable to
> rename our package later.
>
> > - (add-after 'unpack 'patch-xferc-path
> > + (add-after 'unpack 'patch-xfe-paths
>
> Please mention this in the commit log.
>
> > - #:make-flags
> > - (let ((out (assoc-ref %outputs "out")))
> > - (list (string-append "BASH_COMPLETION_DIR=" out
> > - "/share/bash-completion/completions")))))
>
> Please mention the removal of make-flags in the commit log.
Please find the revised patch attached with this email.
Regards,
RG.
0001-gnu-xfe-Fix-configuration-and-icons.patch
Description: Text Data