[bug#36998] [PATCH] services: certbot: Add --manual-public-ip-logging-ok for manual challenges

[Ludovic Courtès]

Hi Carlo,

Time flies…

Carlo Zancanaro <address@hidden> skribis:

> I recently tried to configure the certbot-service with the dns
> challenge type. It failed, because certbot tries to ask whether you're
> okay with letsencrypt knowing (and potentially logging) your IP
> address, but within an mcron task that just fails.
>
> The solution is to add the --manual-public-ip-logging-ok flag, so
> here's a patch to do that!

[...]

> --- a/gnu/services/certbot.scm
> +++ b/gnu/services/certbot.scm
> @@ -99,6 +99,7 @@
>                              "--manual"
>                              (string-append "--preferred-challenges=" 
> challenge)
>                              "--cert-name" name
> +                            "--manual-public-ip-logging-ok"
>                              "-d" (string-join domains ","))

Perhaps we should pass --manual-public-ip-logging-ok only when
‘challenge’ has the expected value (DNS challenge type; what’s the value
for that?), and also document that prominently in the manual?

Thanks,
Ludo’.