guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#36477] [PATCH v3 43/48] utils: Use target-arm64? and target-arm? he


From: Ludovic Courtès
Subject: [bug#36477] [PATCH v3 43/48] utils: Use target-arm64? and target-arm? helpers.
Date: Wed, 04 Sep 2019 14:32:32 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Mathieu Othacehe <address@hidden> skribis:

> * guix/utils.scm (target-arm64?, target-arm?): New exported procedures.
> ---
>  guix/utils.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/guix/utils.scm b/guix/utils.scm
> index f480c3291f..3eb156ad4e 100644
> --- a/guix/utils.scm
> +++ b/guix/utils.scm
> @@ -78,6 +78,8 @@
>              package-name->name+version
>              target-mingw?
>              target-arm32?
> +            target-arm64?
> +            target-arm?
>              target-64bit?
>              version-compare
>              version>?
> @@ -493,6 +495,12 @@ a character other than '@'."
>  (define (target-arm32?)
>    (string-prefix? "arm" (or (%current-target-system) (%current-system))))
>  
> +(define (target-arm64?)
> +  (string-prefix? "aarch64" (or (%current-target-system) (%current-system))))

I’d call it ‘target-aarch64?’ because that’s what it’s called upstream,
and that’s also the name we use elsewhere in Guix.  WDYT?

Apart from that LGTM!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]