[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#36093] [PATCH 1/2] services: Add Singularity.
From: |
Danny Milosavljevic |
Subject: |
[bug#36093] [PATCH 1/2] services: Add Singularity. |
Date: |
Wed, 5 Jun 2019 17:02:17 +0200 |
Hi Ludo,
On Tue, 4 Jun 2019 23:01:14 +0200
Ludovic Courtès <address@hidden> wrote:
> address@hidden {Scheme Variable} singularity-service-type
> +This is the type of the service that runs
> address@hidden://www.sylabs.io/singularity/, Singularity},
Does it?
Doesn't it just "allow you to invoke"?
> + (substitute* (find-files "libexec/cli" "\\.exec$")
> +
> (("\\$SINGULARITY_libexecdir/singularity/bin/([a-z]+)-suid"
> + _ program)
> + (string-append "/run/setuid-programs/singularity-"
> + program "-helper")))
Is absolute path OK? There have been some efforts to get guix to relocate in
the past. Does this apply here?
> + ;; Create the directories that Singularity 2.6 expects to find.
> + (for-each (lambda (directory)
> + (mkdir-p (string-append "/var/singularity/mnt/"
> + directory)))
> + '("container" "final" "overlay" "session")))))
Are permissions OK?
LGTM!
pgpkw89OFiT1S.pgp
Description: OpenPGP digital signature
- [bug#36093] [PATCH 1/2] services: Add Singularity., (continued)
- [bug#36093] [PATCH 1/2] services: Add Singularity., Ludovic Courtès, 2019/06/04
- [bug#36093] [PATCH 2/2] pack: Add '--entry-point'., Ludovic Courtès, 2019/06/04
- [bug#36093] [PATCH 2/2] pack: Add '--entry-point'., Danny Milosavljevic, 2019/06/05
- [bug#36093] [PATCH 2/2] pack: Add '--entry-point'., Ludovic Courtès, 2019/06/05
- [bug#36093] [PATCH v2 1/2] services: Add Singularity., Ludovic Courtès, 2019/06/06
- [bug#36093] [PATCH v2 2/2] pack: Add '--entry-point'., Ludovic Courtès, 2019/06/06
- bug#36093: [PATCH v2 2/2] pack: Add '--entry-point'., Ludovic Courtès, 2019/06/07
- [bug#36093] [PATCH 2/2] pack: Add '--entry-point'., Ricardo Wurmus, 2019/06/07
- [bug#36093] [PATCH 2/2] pack: Add '--entry-point'., Ludovic Courtès, 2019/06/07
- [bug#36093] [PATCH 2/2] pack: Add '--entry-point'., Ricardo Wurmus, 2019/06/08
[bug#36093] [PATCH 1/2] services: Add Singularity.,
Danny Milosavljevic <=