[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33265] [WIP RFC] services: Add file system monitor service.
From: |
Clément Lassieur |
Subject: |
[bug#33265] [WIP RFC] services: Add file system monitor service. |
Date: |
Mon, 05 Nov 2018 10:36:00 +0100 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Hi Danny,
I don't have time to do a proper review, but just one comment:
Danny Milosavljevic <address@hidden> writes:
> + (test-assert "file system monitor running"
> + (marionette-eval
> + '(begin
> + (use-modules (gnu services herd))
> + (match (start-service 'monitor-file-system)
> + (#f #f)
> + (('service response-parts ...)
> + (match (assq-ref response-parts 'running)
> + ((pid) (number? pid))))))
> + marionette))
How is that better than:
(test-assert "file system monitor running"
(marionette-eval
'(begin
(use-modules (gnu services herd))
(start-service 'monitor-file-system))
marionette))
'start-service' should return #f if the service fails to start.
Cheers,
Clément
- [bug#33265] [WIP RFC v3] services: Add file system monitoring service., (continued)
- [bug#33265] [WIP RFC v3] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/04
- [bug#33265] [WIP RFC v3] services: Add file system monitoring service., swedebugia, 2018/11/05
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/05
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Ludovic Courtès, 2018/11/10
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/10
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/10
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Ludovic Courtès, 2018/11/11
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/11
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/11
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Ludovic Courtès, 2018/11/11
[bug#33265] [WIP RFC] services: Add file system monitor service.,
Clément Lassieur <=