[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as T
From: |
Ludovic Courtès |
Subject: |
[bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO. |
Date: |
Sat, 28 Oct 2017 09:51:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hi Eric,
Eric Bavier <address@hidden> skribis:
> On my system, perl-sys-cpu's tests fail because of differences in the
> information available in /proc/cpuinfo.
>
> Debian's patch for this perl module seemed nice: rather than trying to fix
> the related functions, just concede that the module is mostly used just to
> read the number of available processors and mark the other tests as "TODO".
[...]
> + (snippet
> + '(begin
> + ;; Replace test with one that marks cpu_clock and cpu_type
> + ;; as TODO. Borrowed from Debian.
Perhaps make it clear in the comment that we do this because the
contents of /proc/cpuinfo differ based on different factors.
Otherwise LGTM, thanks!
Ludo’.