[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and glib m
From: |
Andy Patterson |
Subject: |
[bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and glib modules support. |
Date: |
Wed, 18 Oct 2017 22:19:06 -0400 |
Hi,
On Mon, 16 Oct 2017 21:25:18 +0800
address@hidden (宋文武) wrote:
> Andy Patterson <address@hidden> writes:
>
> > virt-manager: Enable gtk schemas and glib modules support.
>
> How about: Wrap with GSettings schema and GIO modules search paths.
>
> Otherwise, this patch series look good to me, thanks!
Sounds good, updated patch appened:
--
Andy
From f504ccc9e961e7657261a478e278c142b9006e6b Mon Sep 17 00:00:00 2001
From: Andy Patterson <address@hidden>
Date: Sun, 15 Oct 2017 11:47:16 -0400
Subject: [PATCH] gnu: virt-manager: Wrap with GSettings schema and GIO modules
search paths.
Fixes a crash when opening the file chooser dialog.
* gnu/packages/virtualization.scm (virt-manager)[arguments]
<#:imported-modules>: Add (guix build glib-or-gtk-build-system).
<#:modules>: Import (guix build glib-or-gtk-build-system) as glib-or-gtk:.
<#:arguments>: Add 'glib-or-gtk-compile-schemas and 'glib-or-gtk-wrap.
---
gnu/packages/virtualization.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 4e384e79a..5cdf6d09b 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -499,9 +499,12 @@ virtualization library.")
;; Some of the tests seem to require network access to install virtual
;; machines.
#:tests? #f
+ #:imported-modules ((guix build glib-or-gtk-build-system)
+ ,@%python-build-system-modules)
#:modules ((ice-9 match)
(srfi srfi-26)
(guix build python-build-system)
+ ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
(guix build utils))
#:phases
(modify-phases %standard-phases
@@ -528,7 +531,11 @@ virtualization library.")
`("GI_TYPELIB_PATH" ":" prefix
,(filter identity paths))))
bin-files))
- #t)))))
+ #t))
+ (add-after 'install 'glib-or-gtk-compile-schemas
+ (assoc-ref glib-or-gtk:%standard-phases
'glib-or-gtk-compile-schemas))
+ (add-after 'install 'glib-or-gtk-wrap
+ (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
(inputs
`(("gtk+" ,gtk+)
("gtk-vnc" ,gtk-vnc)
--
2.14.2