[bug#28830] [PATCH] gnu: Add emacs-ggtags.

[Christopher Baines]

On Sat, 14 Oct 2017 12:04:09 +0300
Oleg Pykhalov <address@hidden> wrote:

> From bcd267046dc0ab8e87356519d3e3c60a96f7d5a4 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <address@hidden>
> Date: Sat, 14 Oct 2017 12:03:23 +0300
> Subject: [PATCH] gnu: Add emacs-ggtags.
> 
> * gnu/packages/emacs.scm (emacs-ggtags): New variable.
> ---
>  gnu/packages/emacs.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 66f0a2ebe..62338e998 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1206,6 +1206,51 @@ Using emacs-direnv means that programs started from 
> Emacs will use the
>  environment set through Direnv.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-ggtags
> +  (package
> +    (name "emacs-ggtags")
> +    (version "0.8.12")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "http://elpa.gnu.org/packages/ggtags-";
> +                           version ".el"))
> +       (sha256
> +        (base32
> +         "0ny3llk021g6r0s75xdm4hzpbxv393ddm2r6f2xdk8kqnq4gnirp"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/leoliu/ggtags";)
> +    (synopsis "Frontend to GNU Global source code tagging system")

I'd suggest putting "the" in here, so "Frontend to the GNU Global ...",
as I think that reads better.

> +    (description "@code{ggtags} provides a frontend to GNU Global source code
> +tagging system.
> +
> +Features:
> +
> address@hidden
> address@hidden Build on @code{compile.el} for asynchronicity and its large 
> feature-set.
> address@hidden Automatically update Global's tag files when needed with 
> tuning for
> +large source trees.
> address@hidden Intuitive navigation among multiple matches with mode-line 
> display of
> +current match, total matches and exit status.
> address@hidden Read tag with completion.
> address@hidden Show definition at point.
> address@hidden Jump to #include files.
> address@hidden Support search history and saving a search to 
> register/bookmark.
> address@hidden Query replace.
> address@hidden Manage Global's environment variables on a per-project basis.
> address@hidden Highlight (definition) tag at point.
> address@hidden Abbreviated display of file names.
> address@hidden Support all Global search backends: @code{grep}, 
> @code{idutils}, etc.
> address@hidden Support exuberant ctags @url{http://ctags.sourceforge.net/} and
> address@hidden backend.
> address@hidden Support all Global's output formats: @code{grep}, 
> @code{ctags-x},
> address@hidden etc.
> address@hidden Support projects on remote hosts (e.g. via @code{tramp}).
> address@hidden Support eldoc.
> address@hidden Search @code{GTAGSLIBPATH} for references and symbols.
> address@hidden itemize\n")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-go-mode
>    (package
>      (name "emacs-go-mode")

Similarly with "the GNU Global" in the description. What do you think?
Apart from that, this looks fine to me :)

pgpxBgW9bXx4x.pgp
Description: OpenPGP digital signature