[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#28720] [PATCH 00/23] Enhance building KDE Frameworks.
From: |
Hartmut Goebel |
Subject: |
[bug#28720] [PATCH 00/23] Enhance building KDE Frameworks. |
Date: |
Fri, 6 Oct 2017 16:59:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
Am 06.10.2017 um 16:16 schrieb Thomas Danckaert:
> Maybe you can still shorten the
> commit messages here and there? (I think comments like "Align with the
> version of other kde-frameworks packages." as you wrote with the prison
> update, can be left out.)
Well, this may be a matter of taste. While maintaining PyInstaller, i
learned that it is important to not only state *what* has been changed,
but often also *why* [*]. This will help to understand years later if
this change is still relevant or not. And regarding notes like "Align
with the rest": These are just to avoid somebody is wasting time
thinking "Why the h*ll was only this package updated and not the others."
[*] I have to admit that I'm not doing this here consistently. See
PHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT.
--
Regards
Hartmut Goebel
| Hartmut Goebel | address@hidden |
| www.crazy-compilers.com | compilers which you thought are impossible |
- [bug#28720] [PATCH 15/23] gnu: kio: Adopt a patch from Nix., (continued)
[bug#28720] [PATCH 20/23] gnu: kdeclarative: Reduce the number of warnings when configuring., Hartmut Goebel, 2017/10/06
[bug#28720] [PATCH 19/23] gnu: kglobalaccel: Reduce the number of warnings when configuring., Hartmut Goebel, 2017/10/06
[bug#28720] [PATCH 18/23] gnu: sonnet: Reduce the number of warnings when configuring., Hartmut Goebel, 2017/10/06
[bug#28720] [PATCH 04/23] gnu: kcoreaddons: Add native-input shared-mime-info and a comment., Hartmut Goebel, 2017/10/06
[bug#28720] [PATCH 00/23] Enhance building KDE Frameworks., Thomas Danckaert, 2017/10/06
bug#28720: merged, Hartmut Goebel, 2017/10/13