[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#28562] [PATCHv2] gnu: eudev: Update to 3.2.4 and generate manpages.
From: |
Maxim Cournoyer |
Subject: |
[bug#28562] [PATCHv2] gnu: eudev: Update to 3.2.4 and generate manpages. |
Date: |
Mon, 25 Sep 2017 16:54:57 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Thomas Danckaert <address@hidden> writes:
> Hi Maxim,
>
> thanks for the patch!
>
> Only one thing: we don't have to substitute the location of autoreconf
> in autogen.sh: because autoconf is a native input, its executables are
> already in the build environment PATH:
>
>> + '(#:phases
>> + (modify-phases %standard-phases
>> + (add-before 'configure 'bootstrap
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (substitute* "autogen.sh"
>> + (("autoreconf")
>> + (string-append (assoc-ref inputs "autoconf")
>> + "/bin/autoreconf")))
>
> If you agree, I can push with that change (and will try to remember to
> push to staging :0) ).
>
> Thomas
Hi Thomas,
Thanks for the review! You are right about the unnecessary autoreconf
substitution; I just removed that part and could rebuild
successfully. If you need the modified patch I've attached it.
Thank you!
Maxim
0001-gnu-eudev-Update-to-3.2.4-and-generate-manpages.patch
Description: Text Data
signature.asc
Description: PGP signature