[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#28177] [PATCH 01/12] gnu: Add discount.
From: |
Christopher Baines |
Subject: |
[bug#28177] [PATCH 01/12] gnu: Add discount. |
Date: |
Tue, 12 Sep 2017 21:57:23 +0100 |
On Sun, 10 Sep 2017 15:23:41 +0200
address@hidden (Ludovic Courtès) wrote:
> Christopher Baines <address@hidden> skribis:
>
> > This is required by perl-text-markdown-discount, which is required
> > by ikiwiki.
> >
> > * gnu/packages/markdown.scm (discount) New variable.
>
> [...]
>
> > + (add-before 'configure 'set_ac_default_path
> > + (lambda args
> > + (substitute* "configure.inc"
> > + (("ac_default_path=\".*\"")
> > + (string-append "ac_default_path=\"" (getenv
> > "PATH") "\"")))
> > + #t)))))
>
> Did you check the references of the resulting store item? It seems to
> me that we might end up referring too much if this value is recorded
> in the binary (GCC, Binutils, Make, etc.).
>
> Perhaps we should instead set it to a very specific list, say
> coreutils, grep, sed, or whatever is expected?
The store item references look fine, I think this is just the path the
configure.inc script searches. In looking at this again, I discovered
that setting the AC_PATH environment variable has the same effect, so
I've updated the patch to do that, as well as adding a comment to
clarify that these are used at build time only.
pgpi1pYAKc2aE.pgp
Description: OpenPGP digital signature
- [bug#28177] [PATCH 01/12] gnu: Add discount., Ludovic Courtès, 2017/09/10
- [bug#28177] [PATCH 01/12] gnu: Add discount.,
Christopher Baines <=
- [bug#28177] [PATCH 01/12] gnu: Add discount., Christopher Baines, 2017/09/12
- [bug#28177] [PATCH 02/12] gnu: Add perl-text-markdown-discount., Christopher Baines, 2017/09/12
- [bug#28177] [PATCH 07/12] gnu: Add perl-test-notabs., Christopher Baines, 2017/09/12
- [bug#28177] [PATCH 04/12] gnu: Add perl-test-cpan-meta., Christopher Baines, 2017/09/12
- [bug#28177] [PATCH 06/12] gnu: Add perl-test-memory-cycle., Christopher Baines, 2017/09/12
- [bug#28177] [PATCH 11/12] gnu: Add perl-cgi-session., Christopher Baines, 2017/09/12
- [bug#28177] [PATCH 03/12] gnu: Add perl-test-cpan-meta-json., Christopher Baines, 2017/09/12
- [bug#28177] [PATCH 10/12] gnu: Add perl-yaml-libyaml., Christopher Baines, 2017/09/12
- [bug#28177] [PATCH 08/12] gnu: Add perl-test-eol., Christopher Baines, 2017/09/12
- [bug#28177] [PATCH 09/12] gnu: Add perl-html-scrubber., Christopher Baines, 2017/09/12